Skip to content

Fix the microbenchmarks build #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2021
Merged

Fix the microbenchmarks build #1662

merged 2 commits into from
Feb 12, 2021

Conversation

adamsitnik
Copy link
Member

reported offline by @kunalspathak

[2021/02/12 01:04:06][INFO] /home/helixbot/work/9CF2092C/w/A7AC08F0/e/src/benchmarks/micro/libraries/System.IO.FileSystem/Perf.FileStream.cs(80,17): error CA1416: This call site is reachable on all platforms. 'FileStream.Lock(long, long)' is unsupported on: 'macos'. [/home/helixbot/work/9CF2092C/w/A7AC08F0/e/src/benchmarks/micro/MicroBenchmarks.csproj]
[2021/02/12 01:04:06][INFO] /home/helixbot/work/9CF2092C/w/A7AC08F0/e/src/benchmarks/micro/libraries/System.IO.FileSystem/Perf.FileStream.cs(82,17): error CA1416: This call site is reachable on all platforms. 'FileStream.Unlock(long, long)' is unsupported on: 'macos'. [/home/helixbot/work/9CF2092C/w/A7AC08F0/e/src/benchmarks/micro/MicroBenchmarks.csproj]
[2021/02/12 01:04:06][INFO]     0 Warning(s)
[2021/02/12 01:04:06][INFO]     2 Error(s)

while testing my change I've realized that the 2.1 and 3.1 builds were broken too, so I've fixed them as well

@adamsitnik
apply [UnsupportedOSPlatform("macos")] attribute to the method that w…
802d1fc 
…as recently marked as unsupported on macOS, fix net6.0 build
@adamsitnik
don't use ValueTask.CompletedTask as it was added in net5.0 and was c…
f8bad49 
…ausing netcoreapp2.1 and netcoreapp3.1 builds to fail
@adamsitnik adamsitnik mentioned this pull request Feb 12, 2021
Merged
@adamsitnik adamsitnik merged commit 174601c into dotnet:master Feb 12, 2021
@adamsitnik adamsitnik deleted the lockBuildFix branch February 12, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adamsitnik